linux-kernel - Re: [PATCH 1/2] ds2760: switch to new dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090805165837.GK13236@buzzloop.caiaq.de>
Date:	Wed, 5 Aug 2009 18:58:37 +0200
From:	Daniel Mack <daniel@...aq.de>
To:	Frans Pop <elendil@...net.nl>
Cc:	linux-kernel@...r.kernel.org, szabolcs.gyurko@....hu,
	mreimer@...p.net, cbou@...l.ru
Subject: Re: [PATCH 1/2] ds2760: switch to new dev_pm_ops

On Wed, Aug 05, 2009 at 04:57:47PM +0200, Frans Pop wrote:
> Daniel Mack wrote:
> > +static struct dev_pm_ops ds2760_battery_pm_ops = {
> > +       .suspend        = ds2760_battery_suspend,
> > +       .resume         = ds2760_battery_resume,
> > +};
> 
> Just to make sure...
> 
> Have you followed the earlier discussions on dev_pm_ops conversions and 
> are you aware that if done like this the driver no longer supports 
> hibernation?
> 
> If omitting hibernation is intentional, it should probably be justified in 
> the commit log.
> 
> See http://lkml.org/lkml/2009/7/25/118 for background.

Hmm, I tested that on a embedded hardware platform which doesn't supoprt
hibernation anyway. But you're right, to prevent regressions, .freeze
and .thaw should probably be given as well.

I'll fix that and resend.

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/