lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090805175505.GA6968@kroah.com>
Date:	Wed, 5 Aug 2009 10:55:05 -0700
From:	Greg KH <greg@...ah.com>
To:	David Vrabel <david.vrabel@....com>
Cc:	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>,
	Jan Blunck <jblunck@...e.de>, gregkh@...e.de,
	Harald Hoyer <harald@...hat.com>,
	Scott James Remnant <scott@...ntu.com>
Subject: Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based
 /dev

On Wed, Aug 05, 2009 at 06:43:02PM +0100, David Vrabel wrote:
> Greg KH wrote:
> > 
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -929,6 +929,8 @@ int device_add(struct device *dev)
> >  		error = device_create_sys_dev_entry(dev);
> >  		if (error)
> >  			goto devtattrError;
> > +
> > +		devtmpfs_create_node(dev);
> >  	}
> >  
> >  	error = device_add_class_symlinks(dev);
> [...]
> > --- /dev/null
> > +++ b/drivers/base/devtmpfs.c
> [...]
> > +int devtmpfs_create_node(struct device *dev)
> 
> Returns an int that's never checked.  Is this intentional?
> 
> > +int devtmpfs_delete_node(struct device *dev)
> 
> Similarly.

Probably not, Kay, care to respin this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ