linux-kernel - Re: [PATCH 2/2] security/smack: Use AF_INET for sin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 05 Aug 2009 12:38:23 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Julia Lawall <julia@...u.dk>
CC:	James Morris <jmorris@...ei.org>,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] security/smack: Use AF_INET for sin_family field

Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
>
> Elsewhere the sin_family field holds a value with a name of the form
> AF_..., so it seems reasonable to do so here as well.  Also the values of
> PF_INET and AF_INET are the same.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> struct sockaddr_in sip;
> @@
>
> (
> sip.sin_family ==
> - PF_INET
> + AF_INET
> |
> sip.sin_family !=
> - PF_INET
> + AF_INET
> |
> sip.sin_family =
> - PF_INET
> + AF_INET
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@...u.dk>
>   

Acked-by: Casey Schaufler <casey@...aufler-ca.com>

Yes, this is a correction. Thank you.


> ---
>  security/smack/smack_lsm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -u -p a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -2464,7 +2464,7 @@ static int smack_socket_sendmsg(struct s
>  	/*
>  	 * Perfectly reasonable for this to be NULL
>  	 */
> -	if (sip == NULL || sip->sin_family != PF_INET)
> +	if (sip == NULL || sip->sin_family != AF_INET)
>  		return 0;
>  
>  	return smack_netlabel_send(sock->sk, sip);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/