linux-kernel - Re: mmotm 2009-08-04-14-22 uploaded (ummunotify)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adabpmulvdp.fsf@cisco.com>
Date:	Tue, 04 Aug 2009 21:47:30 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>, akpm@...ux-foundation.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: mmotm 2009-08-04-14-22 uploaded (ummunotify)

Andrew, can you add this into the ummunotify patch, or add it on top or whatever?

Fix

    ummunotify.c:(.text+0x8f217): undefined reference to `__get_user_X'

when building for i386 -- get_user() can't handle u64 on all
architectures, so just use copy_from_user().

Reported-by: Randy Dunlap <randy.dunlap@...cle.com>
Signed-off-by: Roland Dreier <rolandd@...co.com>
---
 drivers/char/ummunotify.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ummunotify.c b/drivers/char/ummunotify.c
index 725fbb0..29de6ab 100644
--- a/drivers/char/ummunotify.c
+++ b/drivers/char/ummunotify.c
@@ -453,7 +453,7 @@ static long ummunotify_unregister_region(struct ummunotify_file *priv,
 	struct ummunotify_reg *reg;
 	int ret = -EINVAL;
 
-	if (get_user(user_cookie, arg))
+	if (copy_from_user(&user_cookie, arg, sizeof user_cookie))
 		return -EFAULT;
 
 	spin_lock_irq(&priv->lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/