linux-kernel - Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1249539447.21101.9.camel@localhost.localdomain>
Date:	Wed, 05 Aug 2009 23:17:27 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Greg KH <greg@...ah.com>
Cc:	"Luis R. Rodriguez" <lrodriguez@...eros.com>,
	linville@...driver.com, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org, zhifeng.cai@...eros.com,
	stephen.chen@...eros.com, linux-usb@...r.kernel.org
Subject: Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID

Hi Luiz,

> > > >> New Atheros USB devices will use 0x0cf3. The first device
> > > >> will be ar9271, for which we are adding support for.
> > > >>
> > > >> Cc: zhifeng.cai@...eros.com
> > > >> Cc: stephen.chen@...eros.com
> > > >> Signed-off-by: Luis R. Rodriguez <lrodriguez@...eros.com>
> > > >> ---
> > > >>
> > > >> John, sending this through you as this is only
> > > >> specific to wireless, at least at the moment.
> > > >>
> > > >>  include/linux/pci_ids.h |    1 +
> > > >>  1 files changed, 1 insertions(+), 0 deletions(-)
> > > >>
> > > >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > > >> index 73b46b6..27f4e6b 100644
> > > >> --- a/include/linux/pci_ids.h
> > > >> +++ b/include/linux/pci_ids.h
> > > >> @@ -2170,6 +2170,7 @@
> > > >>  #define PCI_DEVICE_ID_BCM1250_HT     0x0002
> > > >>
> > > >>  #define PCI_VENDOR_ID_ATHEROS                0x168c
> > > >> +#define PCI_VENDOR_ID_ATHEROS_USB    0x0cf3
> > > >
> > > > this is confusing the hell out of me. What are you adding here.
> > > 
> > > No you're right, my fault.
> > > 
> > > > A USB
> > > > vendor id or a PCI one. Is the ar9271 a PCI device or a USB device?
> > > 
> > > Its only USB.
> > > 
> > > Thanks... hm I see no USB vendor id headers. Guess we won't need to add this.
> > 
> > the closest we have is drivers/hid/hid-ids.h and we might just should
> > have Greg create a usb-ids.h file.
> 
> Ick, no, there's no such file for a good reason.  Put your device ids in
> the driver files, no need to share it across the whole kernel.

that is fine with me btw. I have always done this. I do actually prefer
the plain ids and then a comment above their usage :)

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/