linux-kernel - net/r8169.c: harmless (?) dupe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 6 Aug 2009 13:17:03 +0200
From:	Vincent Pelletier <plr.vincent@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: net/r8169.c: harmless (?) dupe

Hi.

I was searching for rtl8102 support state in the kernel, and reading the 
commit[1] adding support I saw this:

+#define R810X_CPCMD_QUIRK_MASK (\
+       EnableBist | \
+       Mac_dbgo_oe | \
+       Force_half_dup | \
+       Force_half_dup | \   <- dupe
+       Force_txflow_en | \
+       Cxpl_dbg_sel | \

If it is harmless by itself, wouldn't it indicate a missing Force_rxflow_en 
(as in R8168_CPCMD_QUIRK_MASK) ?
I don't have the card yet, so this is no bug report, just wondering.

[1] 2857ffb7b8913ef713533ac5783abd70a20529e4

PS: Please CC me when answering, I'm not subscribed.
-- 
Vincent Pelletier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/