linux-kernel - RE: [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support for sata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1249574363.4530.23.camel@localhost>
Date:	Thu, 06 Aug 2009 16:59:23 +0100
From:	Tony Vroon <tony@...x.net>
To:	Chetan.Loke@...lex.Com
Cc:	hancockrwd@...il.com, jgarzik@...ox.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, philipl@...rt.org
Subject: RE: [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support for
 sata_nv

> disable_msi() is missing right?

I didn't add that as none of the other drivers have it:
chainsaw@...lthea /cvs/linux-2.6/drivers/ata $ grep _msi * | grep pci
ahci.c:		pci_enable_msi(pdev);
sata_mv.c:	if (msi && pci_enable_msi(pdev) == 0)
sata_vsc.c:	if (pci_enable_msi(pdev) == 0)

(This is a tree without the sata_nv change I submitted)

I do believe it is safe to shut the interrupt down and unload the
handler whilst it is still in MSI mode. At least, I don't see the libata
core special-casing it in any way.

> Chetan

Regards,
Tony V.

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)