linux-kernel - Re: [RFC PATCH V2 2/2] introduce ACPI ALS device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Aug 2009 10:50:58 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Zhang Rui <rui.zhang@...el.com>
Cc:	linux-acpi <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>, Greg KH <greg@...ah.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Matthew Wilcox <matthew@....cx>, Len Brown <lenb@...nel.org>,
	"Valdis.Kletnieks@...edu" <Valdis.Kletnieks@...edu>
Subject: Re: [RFC PATCH V2 2/2] introduce ACPI ALS device driver

On Thu, 2009-08-06 at 09:09 -0600, Bjorn Helgaas wrote:

> > +	status = acpi_get_name(als->device->handle, ACPI_FULL_PATHNAME, &name);
> > +	if (ACPI_FAILURE(status)) {
> > +		result = -ENODEV;
> > +		goto end;
> > +	}
> > +
> > +	als->als_sys = als_device_register(&acpi_als_ops, name.pointer, als);
> 
> I don't think we should expose the ACPI pathname of the device here.
> If we really need something in sysfs, I think some kind of link to the
> underlying device would be better.

What I mean to say here is that if we need a connection to the ACPI
pathname (and we might, especially for debugging), I think the
connection should be between "ACPI0008:00" and the pathname, not between
something in /sys/class/als/... and the pathname.

Then you could have a link under /sys/class/als/... to the ACPI0008:00
stuff.

Bjorn


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/