linux-kernel - [PATCH] Address Sparse Static Warning inside kernel/fork.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Aug 2009 22:36:00 +0530
From:	Subrata Modak <subrata@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
	Subrata Modak <subrata@...ux.vnet.ibm.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] Address Sparse Static Warning inside kernel/fork.c

Hi Ingo,

The patch below fixes the following SPARSE warning:
kernel/fork.c:81:5: warning: symbol 'max_threads' was not declared. Should it be static?
kernel/fork.c:171:13: warning: symbol 'fork_init' was not declared. Should it be static?

Signed-off-by: Subrata Modak<subrata@...ux.vnet.ibm.com>

To: Ingo Molnar <mingo@...e.hu>,
Cc: LKML <linux-kernel@...r.kernel.org>,
Cc: Balbir Singh <balbir@...ux.vnet.ibm.com>,
Cc: Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
---

--- a/kernel/fork.c	2009-08-05 12:00:51.000000000 +0530
+++ b/kernel/fork.c	2009-08-06 22:26:30.000000000 +0530
@@ -78,7 +78,7 @@
 unsigned long total_forks;	/* Handle normal Linux uptimes. */
 int nr_threads; 		/* The idle threads do not count.. */
 
-int max_threads;		/* tunable limit on nr_threads */
+static int max_threads;		/* tunable limit on nr_threads */
 
 DEFINE_PER_CPU(unsigned long, process_counts) = 0;
 
@@ -168,7 +168,7 @@ void __put_task_struct(struct task_struc
 #define arch_task_cache_init()
 #endif
 
-void __init fork_init(unsigned long mempages)
+static void __init fork_init(unsigned long mempages)
 {
 #ifndef __HAVE_ARCH_TASK_STRUCT_ALLOCATOR
 #ifndef ARCH_MIN_TASKALIGN

Regards--
Subrata

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/