linux-kernel - Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Aug 2009 14:16:26 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Dave Jones <davej@...hat.com>, Greg KH <greg@...ah.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	"Luis R. Rodriguez" <lrodriguez@...eros.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	zhifeng.cai@...eros.com, stephen.chen@...eros.com,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID

On Thu, Aug 06, 2009 at 02:15:46PM -0400, Dave Jones wrote:
> On Wed, Aug 05, 2009 at 10:09:32PM -0700, Greg Kroah-Hartman wrote:
>  > > the closest we have is drivers/hid/hid-ids.h and we might just should
>  > > have Greg create a usb-ids.h file.
>  >
>  > Ick, no, there's no such file for a good reason.  Put your device ids in
>  > the driver files, no need to share it across the whole kernel.
> 
> I agree. In fact, I'd go further, and say that the bulk of what we have
> in pci_ids.h is also pointlessly shared. Only a tiny fraction of the device
> entries in that file are used by multiple files in the kernel.

Not much point in duplicating the vendor IDs among drivers.  I agree
that sharing the device IDs has no obvious benefit.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/