linux-kernel - [PATCH] Document pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090806191359.GA4345@redhat.com>
Date:	Thu, 6 Aug 2009 15:13:59 -0400
From:	Dave Jones <davej@...hat.com>
To:	Greg KH <greg@...ah.com>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	"Luis R. Rodriguez" <lrodriguez@...eros.com>,
	linville@...driver.com, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org, zhifeng.cai@...eros.com,
	stephen.chen@...eros.com, linux-usb@...r.kernel.org,
	jbarnes@...tuousgeek.org
Subject: [PATCH] Document pci_ids.h addition policy.

On Thu, Aug 06, 2009 at 11:33:26AM -0700, Greg Kroah-Hartman wrote:
 
 > > I agree. In fact, I'd go further, and say that the bulk of what we have
 > > in pci_ids.h is also pointlessly shared. Only a tiny fraction of the device
 > > entries in that file are used by multiple files in the kernel.
 > 
 > I agree with that as well, which is why when I was PCI maintainer, I
 > didn't allow any new additions to the pci_ids.h file, unless it was
 > going to be an id that was shared by different drivers.  That cut the
 > new additions down to about none :)

Perhaps documenting this is a good idea to prevent things being moved there,
as it still seems to be happening judging from the git log.

Signed-off-by: Dave Jones <davej@...hat.com>
 
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 73b46b6..f9156fd 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2,6 +2,9 @@
  *	PCI Class, Vendor and Device IDs
  *
  *	Please keep sorted.
+ *
+ *	Do not add new entries to this file unless the definitions
+ *	are shared between multiple drivers.
  */
 
 /* Device classes and subclasses */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/