linux-kernel - Re: [PATCH 2/2] Dirty page tracking & on-the-fly memory mirroring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 07 Aug 2009 01:06:01 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jim Paradis <jparadis@...hat.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Dirty page tracking & on-the-fly memory mirroring

Jim Paradis <jparadis@...hat.com> writes:

> +#ifdef CONFIG_TRACK_DIRTY_PAGES
> +
> +#if PAGETABLE_LEVELS <= 3
> +static inline unsigned pud_index(unsigned long address)
> +{
> +    return 0;
> +}
> +#endif

Needing special code for different page table levels is a really bad
sign that it uses the wrong abstractions for page tables. It should be using
the standard page walk idioms or perhaps even walk_page_range() now

-Andi


-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/