linux-kernel - Re: [BUG] git 2.6.31-rc3'ish: "<kobject> does not have a release() function, it is broken and must be fixed."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaiqh0ec8c.fsf@cisco.com>
Date:	Thu, 06 Aug 2009 16:47:31 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Greg KH <gregkh@...e.de>
Cc:	Andreas Mohr <andi@...as.de>, Kay Sievers <kay.sievers@...y.org>,
	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au
Subject: Re: [BUG] git 2.6.31-rc3'ish: "<kobject> does not have a release() function, it is broken and must be fixed."


 > Kay, we were cleaning up the kobject name stuff then, and we thought
 > that this release function wasn't used anymore.  But in looking at the
 > code, I can't see where the kobject is actually freed.  What am I
 > missing?

the kobject in question is freed at

  free_module() ->
    mod_kobject_remove() ->
      mod_sysfs_fini() ->
        kobject_put(&mod->mkobj.kobj);

(in kernel/module.c)

Of course the release function you removed in 7a6a4161 was empty so it
wasn't doing anything except satisfying the "all kobjects must have a
release method" diktat.

 - R.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/