linux-kernel - Re: [PATCH] perf tools: Fix cumul hit based sub-total

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1249632778.32113.608.camel@twins>
Date:	Fri, 07 Aug 2009 10:12:58 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Mike Galbraith <efault@....de>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH] perf tools: Fix cumul hit based sub-total

On Fri, 2009-08-07 at 07:11 +0200, Frederic Weisbecker wrote:
> The callchain fractal mode builds each new total hits in a new branch
> of profiling by using the parent's hits of the current branch plus the
> hits of the children.
> 
> This is wrong, the total hits of a branch should be made of the sum of
> every children hits, we must ignore the parent hits in this scope.
> 
> This patch also fixes another mistakes with the hit counting.
> 
> Now the rates are corrects.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Mike Galbraith <efault@....de>
> ---

Ah will this fix these instances where you'd have things like

                |                     page_fault
                |                     |
                |                     |--100.00%-- __strcmp_sse2
                |                     |          copy_dep_chain
                |                     |          __libc_start_main
                |                     |
                |                      --100.00%-- gettimeofday
                |                                __libc_start_main


I was meaning to poke you about that :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/