linux-kernel - Re: [PATCH 3/5] tty: handle VT specific compat ioctls in vt driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908071402.11217.arnd@arndb.de>
Date:	Fri, 7 Aug 2009 14:02:11 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
	Andi Kleen <andi@...stfloor.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	"Greg Kroah-Hartman" <gregkh@...e.de>
Subject: Re: [PATCH 3/5] tty: handle VT specific compat ioctls in vt driver

On Friday 07 August 2009, Frederic Weisbecker wrote:
> Ok. This looks like a nice series. A bkl pushdown that only goes down
> in one site among several others enlightens the understanding of what it
> is protecting (beside the nice fact it also burned three bkl callsites :-)

Thanks!

Well, most importantly patch 5/5 fixes a long-standing bug where we held
the BKL in lots of places that were already proven not to need it, or
alternatively held it twice (nested) in the ioctls that may still need it.

I did patch 3/5 this way because I read that you were working on BKL
removal for TTY and wanted to do my share by removing the dependency
on the code that I care about (fs/compat_ioctl.h).

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/