linux-kernel - Re: [PATCH] amd64_edac: Rewrite unganged mode code of f10_early_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090807151102.GE29900@aftab>
Date:	Fri, 7 Aug 2009 17:11:02 +0200
From:	Borislav Petkov <borislav.petkov@....com>
To:	wan wei <onewayforever@...il.com>
CC:	dougthompson@...ssion.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] amd64_edac: Rewrite unganged mode code of
 f10_early_channel_count

On Fri, Aug 07, 2009 at 10:39:39PM +0800, wan wei wrote:
> simplify the procedure by checking if there is any dimm  in each channel.
> this patch will fix the bugs such as when there is no dimms  under
> certain node,  two dimms in the same channel, and only one dimm in
> each channel of the node.
> 
> Signed-off-by: Wan Wei<wanwei@...l.dawning.com.cn>
> ---
>  drivers/edac/amd64_edac.c |   43 ++++++++++---------------------------------
>  1 files changed, 10 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index e2a10bc..acf9cfe 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -1200,6 +1200,8 @@ static int f10_early_channel_count(struct amd64_pvt *pvt)
>  {
>  	int err = 0, channels = 0;
>  	u32 dbam;
> +	int i, j;
> +	int dbams[] = { DBAM0, DBAM1 };
> 
>  	err = pci_read_config_dword(pvt->dram_f2_ctl, F10_DCLR_0, &pvt->dclr0);
>  	if (err)
> @@ -1232,45 +1234,20 @@ static int f10_early_channel_count(struct
> amd64_pvt *pvt)

Thanks.

patching file drivers/edac/amd64_edac.c
patch: **** malformed patch at line 28: amd64_pvt *pvt)

Your patch is still garbled, I've applied it by hand this time. For the
future, please send a patch privately to yourself first and try applying
it to check whether your mail client mangles it.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/