linux-kernel - Re: [PATCH v2 2/3] tracing/filters: Add __field_ext() to TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0908062251050.2840@gandalf.stny.rr.com>
Date:	Thu, 6 Aug 2009 22:51:18 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Li Zefan <lizf@...fujitsu.com>
cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH v2 2/3] tracing/filters: Add __field_ext() to
 TRACE_EVENT



On Fri, 7 Aug 2009, Li Zefan wrote:

> >>  #define is_signed_type(type)	(((type)(-1)) < 0)
> >>  
> >> @@ -165,7 +172,7 @@ do {									\
> >>  #define __common_field(type, item, is_signed)				\
> >>  	ret = trace_define_field(event_call, #type, "common_" #item,	\
> >>  				 offsetof(typeof(field.ent), item),	\
> >> -				 sizeof(field.ent.item), is_signed);	\
> >> +				 sizeof(field.ent.item), is_signed, -1);\
> > 
> > I think this wants to be FILTER_OTHER?
> > 
> 
> oops.. I thought I had changed all -1 to FILTER_OTHER..
> 
> I guess you're going to fix this manually?

Yeah, I can make that change.

Thanks!

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/