linux-kernel - Re: [Patch v3] vfs: allow file truncations when both suid and write permissions set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1249675025.2694.15.camel@dhcp231-106.rdu.redhat.com>
Date:	Fri, 07 Aug 2009 15:57:05 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, esandeen@...hat.com, eteo@...hat.com,
	linux-fsdevel@...r.kernel.org, akpm@...ux-foundation.org,
	hirofumi@...l.parknet.co.jp, viro@...iv.linux.org.uk
Subject: Re: [Patch v3] vfs: allow file truncations when both suid and
 write permissions set

On Fri, 2009-08-07 at 06:05 -0400, Amerigo Wang wrote:
> V2 -> V3:
> Call notify_change() before clearing suid/sgid.
> Thanks to OGAWA Hirofumi.
> 
> V1 -> V2:
> Introduce dentry_remove_suid(), and use it in do_truncate().
> Thanks to Eric Paris.
> 
> 
> When suid is set and the non-owner user has write permission,
> any writing into this file should be allowed and suid should be
> removed after that.
> 
> However, current kernel only allows writing without truncations,
> when we do truncations on that file, we get EPERM. This is a bug.
> 
> Steps to reproduce this bug:
> 
> % ls -l rootdir/file1
> -rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1
> % echo h > rootdir/file1
> zsh: operation not permitted: rootdir/file1
> % ls -l rootdir/file1
> -rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1
> % echo h >> rootdir/file1
> % ls -l rootdir/file1
> -rwxrwxrwx 1 root root 5 Jun 25 16:34 rootdir/file1
> 
> This patch fixes it.
> 
> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: Eric Sandeen <esandeen@...hat.com>
> Cc: Eric Paris <eparis@...hat.com>
> Cc: Eugene Teo <eteo@...hat.com>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: hirofumi@...l.parknet.co.jp

I was thinking about this and kept telling myself I was going to test v2
before I ack/nak.  Clearly we shouldn't for the dropping of SUID if the
process didn't have permission to change the ATTR_SIZE.

Acked-by: Eric Paris <eparis@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/