linux-kernel - Re: [PATCH 6/6] [ARM] Use atomic_spin_lock/atomic_spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090807205411.GA2422@pengutronix.de>
Date:	Fri, 7 Aug 2009 22:54:11 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	rt-users <linux-rt-users@...r.kernel.org>
Subject: Re: [PATCH 6/6] [ARM] Use atomic_spin_lock/atomic_spin_unlock for
	irqdesc lock

Hello,

> diff --git a/mm/highmem.c b/mm/highmem.c
> index 66e915a..214eefd 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -372,8 +372,8 @@ void *kmap_high_get(struct page *page)
>  	lock_kmap_any(flags);
>  	vaddr = (unsigned long)page_address(page);
>  	if (vaddr) {
> -		BUG_ON(pkmap_count[PKMAP_NR(vaddr)] < 1);
> -		pkmap_count[PKMAP_NR(vaddr)]++;
> +		BUG_ON(atomic_read(&pkmap_count[PKMAP_NR(vaddr)]) < 1);
> +		atomic_add(1, pkmap_count[PKMAP_NR(vaddr)]);
>  	}
>  	unlock_kmap_any(flags);
>  	return (void*) vaddr;
ups, this hunk doesn't belong here.  I will follow up with a corrected
patch.

Sorry
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/