linux-kernel - Re: [ofa-general] IB kernel modules and the kobject release() method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2e108260908070026s10658adl2c4a9a5b3eba1a08@mail.gmail.com>
Date:	Fri, 7 Aug 2009 09:26:33 +0200
From:	Bart Van Assche <bart.vanassche@...il.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	OpenIB <general@...ts.openfabrics.org>,
	LKML <linux-kernel@...r.kernel.org>, Greg KH <gregkh@...e.de>
Subject: Re: [ofa-general] IB kernel modules and the kobject release() method

On Thu, Aug 6, 2009 at 9:58 PM, Roland Dreier<rdreier@...co.com> wrote:
>
>  > Are you sure that this indicates a shortcoming in the kobject
>  > debugging code ? The most recent messages related to the message "does
>  > not have a release() function, it is broken and must be fixed" I could
>  > find on the LKML date from July 16, 2009
>  > (http://lkml.org/lkml/2009/7/16/306 and
>  > http://lkml.org/lkml/2009/7/16/391). As you can see Greg KH
>  > acknowledges that if this message is logged that this indicates a
>  > problem that should be fixed.
>
> I'm not sure -- I just assume that the core module unloading code is
> working OK, since it is so heavily tested.  If there were really a "must
> be fixed" problem with module unloading then someone would surely have
> hit more than a warning message.

(added Greg KH and the LKML in CC)

I tried to look up more information about kobjects. The comment of
commit 7a6a41615bfb2f03ce797bc24104c50b42c935e5 suggests that in the
past the function kobject_cleanup() did not free the memory allocated
for static kobject names but that this was the responsibility of the
release() function. This should have been fixed in the current version
of kobject_cleanup(). So I'm wondering whether the message that
kobjects that do not have a release() function are broken still makes
sense ?

See also
* http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7a6a41615bfb2f03ce797bc24104c50b42c935e5.
* http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.30.y.git;a=blob;f=lib/kobject.c

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/