linux-kernel - RE: [patch] x86, perf_counter, bts: add bts to perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <928CFBE8E7CB0040959E56B4EA41A77EC1BFEEE3@irsmsx504.ger.corp.intel.com>
Date:	Fri, 7 Aug 2009 08:29:05 +0100
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [patch] x86, perf_counter, bts: add bts to perf_counter

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@...e.hu]
>Sent: Tuesday, August 04, 2009 1:36 PM
>To: Peter Zijlstra
>Cc: Metzger, Markus T; tglx@...utronix.de; hpa@...or.com; markus.t.metzger@...il.com; linux-
>kernel@...r.kernel.org
>Subject: Re: [patch] x86, perf_counter, bts: add bts to perf_counter
>
>
>* Ingo Molnar <mingo@...e.hu> wrote:
>
>> > Over all looks very nice, some comments below (could be
>> > addressed in a delta patch).
>>
>> ok - thanks guys - i'll test this some and push it out into the
>> perfcounters tree. Will apply the delta patch too once it's done.
>
>the kernel hard-locks if i try to use it:
>
> titan:~/tip/tools/perf> perf record -f -e branches -c 1 ~/hackbench 1
>
>with the attached 64-bit (def-)config, on a Core2 test-box, latest
>-tip.

Ingo, thanks for reporting the issue!

I forgot to set the BTINT bit.

I now also set pending_kill = POLL_IN as perf_counter_overflow() would do when draining BTS.

I incorporated Peter's review comments, except that I would not enforce sample_period == 1
when branch tracing is requested. There might be users who want to sample the IP every 100.000'th
branch for profiling reasons.

regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/