[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 8 Aug 2009 16:45:20 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Jesse Barnes <jbarnes@...tuousgeek.org>
Cc: Jeremy Fitzhardinge <jeremy@...p.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...hat.com>,
the arch/x86 maintainers <x86@...nel.org>,
Stefan Assmann <sassmann@...e.de>
Subject: Re: drivers/pci/quirks.c: irq_reroute_variant is dead code?
* Jesse Barnes <jbarnes@...tuousgeek.org> wrote:
> On Tue, 28 Jul 2009 12:50:08 -0700
> Jeremy Fitzhardinge <jeremy@...p.org> wrote:
>
> > quirk_reroute_to_boot_interrupts_intel() goes to some effort to
> > scan for a bunch of Intel devices and set
> > dev->irq_reroute_variant = INTEL_IRQ_REROUTE_VARIANT. However,
> > as far as I can see that's the only reference to
> > dev->irq_reroute_variant and INTEL_IRQ_REROUTE_VARIANT, so the
> > whole thing appears to have no effect.
> >
> > Is it all dead code? Is there something else which should be
> > there missing?
>
> Hm my quick look couldn't find a user either. The initial patch
> to add that stuff (e1d3a90846b40ad3160bf4b648d36c6badad39ac) had
> an ACPI component, but it looks like that may have vanished
> somehow (maybe some of the IOAPIC code got shuffled around and
> this bit was missed?).
>
> Stefan or Ingo?
I dont remember ioapic interactions. Stefan?
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists