linux-kernel - [tip:irq/core] irq: Remove superfluous NULL pointer check in check_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-139183d579d6097cdbbd64825bbac54d8481a144@git.kernel.org>
Date:	Sat, 8 Aug 2009 16:21:37 GMT
From:	tip-bot for Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, julia@...u.dk, hpa@...or.com,
	mingo@...hat.com, bzolnier@...il.com, eteo@...hat.com,
	corbet@....net, error27@...il.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:irq/core] irq: Remove superfluous NULL pointer check in check_irq_resend()

Commit-ID:  139183d579d6097cdbbd64825bbac54d8481a144
Gitweb:     http://git.kernel.org/tip/139183d579d6097cdbbd64825bbac54d8481a144
Author:     Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
AuthorDate: Thu, 6 Aug 2009 21:46:03 +0200
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Sat, 8 Aug 2009 18:18:05 +0200

irq: Remove superfluous NULL pointer check in check_irq_resend()

This takes care of the following entry from Dan's list:

kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'

Reported-by: Dan Carpenter <error27@...il.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc: Jonathan Corbet <corbet@....net>
Cc: Eugene Teo <eteo@...hat.com>
Cc: Julia Lawall <julia@...u.dk>
LKML-Reference: <200908062146.03638.bzolnier@...il.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 kernel/irq/resend.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/resend.c b/kernel/irq/resend.c
index 89c7117..090c376 100644
--- a/kernel/irq/resend.c
+++ b/kernel/irq/resend.c
@@ -70,8 +70,7 @@ void check_irq_resend(struct irq_desc *desc, unsigned int irq)
 	if ((status & (IRQ_LEVEL | IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) {
 		desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY;
 
-		if (!desc->chip || !desc->chip->retrigger ||
-					!desc->chip->retrigger(irq)) {
+		if (!desc->chip->retrigger || !desc->chip->retrigger(irq)) {
 #ifdef CONFIG_HARDIRQS_SW_RESEND
 			/* Set it pending and activate the softirq: */
 			set_bit(irq, irqs_resend);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/