linux-kernel - Re: [PATCH tip:x86/asm] x86: Introduce GDT_ENTRY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A7DE8B6.80801@zytor.com>
Date:	Sat, 08 Aug 2009 14:05:58 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
CC:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH tip:x86/asm] x86: Introduce GDT_ENTRY_INIT()

On 08/08/2009 02:49 AM, Akinobu Mita wrote:
> diff --git a/drivers/char/vr41xx_giu.c b/drivers/char/vr41xx_giu.c
> deleted file mode 100644
> index e69de29..0000000
> diff --git a/drivers/pnp/pnpbios/bioscalls.c b/drivers/pnp/pnpbios/bioscalls.c
> index 45ad3e9..bd035e3 100644
> --- a/drivers/pnp/pnpbios/bioscalls.c
> +++ b/drivers/pnp/pnpbios/bioscalls.c
> @@ -60,7 +60,7 @@ do { \
>  	set_desc_limit(&gdt[(selname) >> 3], (size) - 1); \
>  } while(0)
>  
> -static struct desc_struct bad_bios_desc;
> +static struct desc_struct bad_bios_desc = GDT_ENTRY_INIT(0x4092, 0, 0);
>  
>  /*
>   * At some point we want to use this stack frame pointer to unwind
> @@ -476,9 +476,6 @@ void pnpbios_calls_init(union pnp_bios_install_struct *header)
>  	pnp_bios_callpoint.offset = header->fields.pm16offset;
>  	pnp_bios_callpoint.segment = PNP_CS16;
>  
> -	bad_bios_desc.a = 0;
> -	bad_bios_desc.b = 0x00409200;
> -
>  	set_desc_base(&bad_bios_desc, (unsigned long)__va(0x40UL << 4));
>  	set_desc_limit(&bad_bios_desc, 4095 - (0x40 << 4));
>  	for_each_possible_cpu(i) {

Please also fix this hunk to do the full initialization statically
instead of doing some fields statically and some dynamically.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/