linux-kernel - Re: [PATCH] fat: Read buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1249726352.8101.0.camel@penberg-laptop>
Date:	Sat, 08 Aug 2009 13:12:32 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	Roel Kluin <roel.kluin@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fat: Read buffer overflow

On Sat, 2009-08-08 at 19:10 +0900, OGAWA Hirofumi wrote:
> Pekka Enberg <penberg@...helsinki.fi> writes:
> 
> > Yes, but we pass "ulen" to vfat_is_used_badchars(). The value of
> > "ulen" is a returned in the "longlen" argument of xlate_to_uni() which
> > in turn is calculated as follows for the UTF-8 case:
> >
> >   int name_len = strlen(name);
> >   *outlen = utf8s_to_utf16s(name, PATH_MAX, (wchar_t *) outname);
> >   *outlen -= (name_len - len);
> >   *longlen = *outlen;
> >
> > Maybe "*outlen" can never be negative because of some invariants that
> > I don't see but it's so non-obvious to me that I'd like to see the
> > explicit check in vfat_is_used_badchars().
> 
> Ah, good point. Sorry, I was looking my tree. I'm going to submit the
> attached patch on next merge window.
> 
> Is this enough for it?

Fine by me!

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/