linux-kernel - Re: [PATCH 10/14] infiniband: use printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaocqo9sb4.fsf@cisco.com>
Date:	Sun, 09 Aug 2009 22:00:31 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Roland Dreier <rolandd@...co.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	general@...ts.openfabrics.org
Subject: Re: [PATCH 10/14] infiniband: use printk_once


 >  drivers/infiniband/hw/cxgb3/iwch.c |    4 +---
 >  drivers/infiniband/hw/mlx4/main.c  |    6 +-----

 > --- a/drivers/infiniband/hw/mlx4/main.c
 > +++ b/drivers/infiniband/hw/mlx4/main.c
 > @@ -540,15 +540,11 @@ static struct device_attribute *mlx4_class_attributes[] = {
 >  
 >  static void *mlx4_ib_add(struct mlx4_dev *dev)
 >  {
 > -	static int mlx4_ib_version_printed;
 >  	struct mlx4_ib_dev *ibdev;
 >  	int num_ports = 0;
 >  	int i;
 >  
 > -	if (!mlx4_ib_version_printed) {
 > -		printk(KERN_INFO "%s", mlx4_ib_version);
 > -		++mlx4_ib_version_printed;
 > -	}
 > +	printk_once(KERN_INFO "%s", mlx4_ib_version);
 >  
 >  	mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_IB)
 >  		num_ports++;

Looks fine but there is near-identical code in
drivers/infiniband/hw/mthca/mthca_main.c that you might as well convert
too.

Thanks,
  Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/