[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090810100818.3c17def9@tlielax.poochiereds.net>
Date: Mon, 10 Aug 2009 10:08:18 -0400
From: Jeff Layton <jlayton@...hat.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org, hch@...radead.org, rlove@...gle.com,
msb@...gle.com, viro@...iv.linux.org.uk, hannes@...xchg.org
Subject: Re: [PATCH 1/3] vfs: make get_sb_pseudo set s_maxbytes to value
that can be cast to signed
On Mon, 10 Aug 2009 09:49:50 -0400
Christoph Hellwig <hch@...radead.org> wrote:
> On Mon, Aug 10, 2009 at 08:17:41AM -0400, Jeff Layton wrote:
> > get_sb_pseudo sets s_maxbytes to ~0ULL which becomes negative when cast
> > to a signed value. Fix it to use MAX_LFS_FILESIZE which casts properly
> > to a positive signed value.
> >
> > Signed-off-by: Jeff Layton <jlayton@...hat.com>
> > Reviewed-by: Johannes Weiner <hannes@...xchg.org>
> > Acked-by: Steve French <smfrench@...il.com>
>
> Looks good, and I think it would be very good to still gets this into
> 2.6.31.
>
> Reviewed-by: Christoph Hellwig <hch@....de>
>
Agreed. The other two should probably go in early 2.6.32 (assuming
they're ok).
--
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists