linux-kernel - Re: [PATCH v2] markup_oops: Use modinfo to avoid confusion with underscored module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090810143725.GA7173@hack>
Date:	Mon, 10 Aug 2009 22:37:25 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Ozan Çağlayan <ozan@...dus.org.tr>
Cc:	linux-kernel@...r.kernel.org, arjan@...radead.org
Subject: Re: [PATCH v2] markup_oops: Use modinfo to avoid confusion with
	underscored module names

On Mon, Aug 10, 2009 at 12:13:13PM +0300, Ozan Çağlayan wrote:
>When EIP is at a module having an underscore in its name, the current
>code fails to find it because the module filenames has '-' instead of
>'_'. Use modinfo for a better path finding.
>
>Signed-off-by: Ozan Çağlayan <ozan@...dus.org.tr>

Acked-by: WANG Cong <xiyou.wangcong@...il.com>

Thanks!

>---
> scripts/markup_oops.pl |    5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
>diff --git a/scripts/markup_oops.pl b/scripts/markup_oops.pl
>index 8977401..5f0fcb7 100644
>--- a/scripts/markup_oops.pl
>+++ b/scripts/markup_oops.pl
>@@ -184,10 +184,7 @@ if ($target eq "0") {
> 
> # if it's a module, we need to find the .ko file and calculate a load offset
> if ($module ne "") {
>-	my $dir = dirname($filename);
>-	$dir = $dir . "/";
>-	my $mod = $module . ".ko";
>-	my $modulefile = `find $dir -name $mod | head -1`;
>+	my $modulefile = `modinfo $module | grep '^filename:' | awk '{ print \$2 }'`;
> 	chomp($modulefile);
> 	$filename = $modulefile;
> 	if ($filename eq "") {
>-- 
>1.6.3.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/