linux-kernel - Re: [PATCH] Staging: vme: fix {master,slave}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A804FEE.8040601@gefanuc.com>
Date:	Mon, 10 Aug 2009 17:50:54 +0100
From:	Martyn Welch <martyn.welch@...anuc.com>
To:	"Emilio G. Cota" <cota@...ap.org>
CC:	Greg K-H <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org
Subject: Re: [PATCH] Staging: vme: fix {master,slave}_get check bug

Emilio G. Cota wrote:
> It's checking the wrong functions; fix it.
>
> Signed-off-by: Emilio G. Cota <cota@...ap.org>
>   
Acked-by: Martyn Welch <martyn.welch@...anuc.com>
> ---
>  drivers/staging/vme/vme.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index 8ee1192..ed2eeb0 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -338,7 +338,7 @@ int vme_slave_get (struct vme_resource *resource, int *enabled,
>  
>  	image = list_entry(resource->entry, struct vme_slave_resource, list);
>  
> -	if (bridge->slave_set == NULL) {
> +	if (bridge->slave_get == NULL) {
>  		printk("vme_slave_get not supported\n");
>  		return -EINVAL;
>  	}
> @@ -499,7 +499,7 @@ int vme_master_get (struct vme_resource *resource, int *enabled,
>  
>  	image = list_entry(resource->entry, struct vme_master_resource, list);
>  
> -	if (bridge->master_set == NULL) {
> +	if (bridge->master_get == NULL) {
>  		printk("vme_master_set not supported\n");
>  		return -EINVAL;
>  	}
>   


-- 
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,        |Registered in England and Wales
Tove Valley Business Park, Towcester,      |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/