[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4A80702D.20701@gmail.com>
Date: Mon, 10 Aug 2009 21:08:29 +0200
From: Artur Skawina <art.08.09@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
CC: Ray Lee <ray-lk@...rabbit.org>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
"Rafael J. Wysocki" <rjw@...k.pl>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: xterm loses data (pty regression)
Linus Torvalds wrote:
>
>> (Do ^S/^Q, see data loss)
> I think it's really this trivial.
>
> That pty commit removed the checking for tty->stopped in
> pty_write_buffer() for no clear reason. And when it did that, it broke all
> the pausing logic in drivers/char/n_tty.c.
>
> Can you confirm?
> static int pty_write_room(struct tty_struct *tty)
> {
> + if (tty->stopped)
> + return 0;
> return pty_space(tty->link);
> }
w/ this, the pty writes now block again after ^Q, and the data loss is gone.
Thanks,
artur
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists