linux-kernel - Re: [PATCH] wl1271: fix compiler warnings on 64 bit archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090811200746.cde6aed9.sfr@canb.auug.org.au>
Date:	Tue, 11 Aug 2009 20:07:46 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Luciano Coelho <luciano.coelho@...ia.com>
Cc:	linux-wireless@...r.kernel.org, linville@...driver.com,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wl1271: fix compiler warnings on 64 bit archs

Hi Luciano,

On Tue, 11 Aug 2009 11:58:27 +0300 Luciano Coelho <luciano.coelho@...ia.com> wrote:
>
> +++ b/drivers/net/wireless/wl12xx/wl1271_boot.c
> @@ -100,8 +100,8 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf,
>  
>  	wl1271_debug(DEBUG_BOOT, "starting firmware upload");
>  
> -	wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d", fw_data_len,
> -		CHUNK_SIZE);
> +	wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d",
> +		     (u32) fw_data_len, CHUNK_SIZE);

fw_data_len is a size_t and so should be printed with %zd.

> @@ -148,7 +148,7 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf,
>  	addr = dest + chunk_num * CHUNK_SIZE;
>  	p = buf + chunk_num * CHUNK_SIZE;
>  	wl1271_debug(DEBUG_BOOT, "uploading fw last chunk (%d B) 0x%p to 0x%x",
> -		     fw_data_len % CHUNK_SIZE, p, addr);
> +		     (u32) fw_data_len % CHUNK_SIZE, p, addr);

ditto.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped