linux-kernel - Re: [Bug #13935] 2.6.31-rcX breaks Apple MightyMouse (Bluetooth version)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87hbwewlk4.fsf@scholz.fias.uni-frankfurt.de>
Date:	Tue, 11 Aug 2009 15:02:19 +0200
From:	Jan Scholz <scholz@...s.uni-frankfurt.de>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	"Adrian Ulrich" <kernel@...nkenlights.ch>,
	"Jiri Kosina" <jkosina@...e.cz>
Subject: Re: [Bug #13935] 2.6.31-rcX breaks Apple MightyMouse (Bluetooth version)

Hi,

I can confirm the reported bug, but for me reverting fa047e4f6fa63a6 is
not sufficient. I have to remove the device id of the mighty mouse from
the hid_blacklist list in drivers/hid/hid-core.c as well, see the patch below.

Concerning the need for the quirks: I think there might be some
dependence on the version of X that is used. If I recall correctly, with
xorg-server-1.3 the quirk "APPLE_INVERT_HWHEEL" was necessary, but this
changed when I switched to xorg-server-1.5.3, where now horizontal
scrolling moves in directions you'd expect from vertical scrolling.
...but I wouldn't bet on my memory regarding things with xorg-server-1.3
since it's been quite some time ago and I never really liked the
horizontal scrolling anyway.

Cheers,
Jan

"Rafael J. Wysocki" <rjw@...k.pl> writes:

> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.30.  Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=13935
> Subject		: 2.6.31-rcX breaks Apple MightyMouse (Bluetooth version)
> Submitter	: Adrian Ulrich <kernel@...nkenlights.ch>
> Date		: 2009-08-08 22:08 (2 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fa047e4f6fa63a6e9d0ae4d7749538830d14a343
>

>From b7393ed6dfe00c9e126a2dd34659156548df15cc Mon Sep 17 00:00:00 2001
From: Jan Scholz <Scholz@...s.uni-frankfurt.de>
Date: Tue, 11 Aug 2009 14:33:27 +0200
Subject: [PATCH] HID: commit fa047e4f is incomplete

Commit fa047e4f6fa63a6e9d0ae4d7749538830d14a343 "HID: fix inverted
wheel for bluetooth version of apple mighty mouse" is incomplete. If
we remove Apple MightyMouse (bluetooth version) from the list of
apple_devices in drivers/hid/hid-apple.c we have to remove it from
hid_blacklist in drivers/hid/hid-core.c as well.

Signed-off-by: Jan Scholz <Scholz@...s.uni-frankfurt.de>
---
 drivers/hid/hid-core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 5eb10c2..047844d 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1319,7 +1319,6 @@ static const struct hid_device_id hid_blacklist[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },

-	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, 0x030c) },
 	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) },
 	{ }
 };
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/