linux-kernel - Re: [PATCH 12/14] scsi: use printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250009378.8895.425.camel@Joe-Laptop.home>
Date:	Tue, 11 Aug 2009 09:49:38 -0700
From:	Joe Perches <joe@...ches.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Marcin Slusarz <marcin.slusarz@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 12/14] scsi: use printk_once

On Tue, 2009-08-11 at 11:40 -0500, James Bottomley wrote:
> On Sun, 2009-08-09 at 21:54 +0200, Marcin Slusarz wrote:
> > --- a/drivers/scsi/cxgb3i/cxgb3i_init.c
> > +++ b/drivers/scsi/cxgb3i/cxgb3i_init.c
> > @@ -43,12 +43,7 @@ static struct cxgb3_client t3c_client = {
> >   */
> >  static void open_s3_dev(struct t3cdev *t3dev)
> >  {
> > -	static int vers_printed;
> > -
> > -	if (!vers_printed) {
> > -		printk(KERN_INFO "%s", version);
> > -		vers_printed = 1;
> > -	}
> > +	printk_once(KERN_INFO "%s", version);
> 
> There's really no point to this beyond code churn.  Both patterns are
> correct uses so conversion buys us nothing.

Standards are for hacks.  Stasis is the best policy.
Using patterns isn't worth the electron movement.
Code shortening and readability?  Humbug.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/