linux-kernel - Re: [PATCH] wl1271: fix compiler warnings on 64 bit archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Aug 2009 11:45:18 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Luciano Coelho <luciano.coelho@...ia.com>
Cc:	ext Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linville@...driver.com" <linville@...driver.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wl1271: fix compiler warnings on 64 bit archs

On Tue, 11 Aug 2009 21:41:11 +0300 Luciano Coelho wrote:

> ext Stephen Rothwell wrote:
> > Hi Luciano,
> >
> > On Tue, 11 Aug 2009 11:58:27 +0300 Luciano Coelho <luciano.coelho@...ia.com> wrote:
> >   
> >> +++ b/drivers/net/wireless/wl12xx/wl1271_boot.c
> >> @@ -100,8 +100,8 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf,
> >>  
> >>  	wl1271_debug(DEBUG_BOOT, "starting firmware upload");
> >>  
> >> -	wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d", fw_data_len,
> >> -		CHUNK_SIZE);
> >> +	wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d",
> >> +		     (u32) fw_data_len, CHUNK_SIZE);
> >>     
> >
> > fw_data_len is a size_t and so should be printed with %zd.
> >
> >   
> >> @@ -148,7 +148,7 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf,
> >>  	addr = dest + chunk_num * CHUNK_SIZE;
> >>  	p = buf + chunk_num * CHUNK_SIZE;
> >>  	wl1271_debug(DEBUG_BOOT, "uploading fw last chunk (%d B) 0x%p to 0x%x",
> >> -		     fw_data_len % CHUNK_SIZE, p, addr);
> >> +		     (u32) fw_data_len % CHUNK_SIZE, p, addr);
> >>     
> >
> > ditto.
> >   
> 
> Thanks! I didn't know about the z length modifier for printf (everyday 
> learning something new!), I should have checked the manpage.  I'll fix 
> this and send v2 of my patch.

man page is fine, but you can also check (in the kernel source tree)
Documentation/printk-formats.txt


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/