linux-kernel - Re: [PATCH] md: avoid use of broken kzalloc mempool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090811145258.6cd823d6.akpm@linux-foundation.org>
Date:	Tue, 11 Aug 2009 14:52:58 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"NeilBrown" <neilb@...e.de>
Cc:	sage@...dream.net, linux-kernel@...r.kernel.org,
	linux-raid@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] md: avoid use of broken kzalloc mempool

On Tue, 4 Aug 2009 08:03:52 +1000 (EST)
"NeilBrown" <neilb@...e.de> wrote:

> On Tue, August 4, 2009 6:54 am, Sage Weil wrote:
> > The kzalloc mempool does not re-zero items that have been used and then
> > returned to the pool.  Manually zero the allocated multipath_bh instead.
> >
> > CC: linux-raid@...r.kernel.org
> > CC: Neil Brown <neilb@...e.de>
> > CC: <stable@...nel.org>

Sage, why did you cc stable@...nel.org?  The patch fixes some bug? 
What is it?  Why is the fix sufficiently important to warrant
backporting?

> Acked-by: NeilBrown <neilb@...e.de>
> 

Thanks, I'll merge it once the above is understood.

> 
> In fact, you don't even need the memset.  After allocation
> no assumptions are made about the content of the structure.
> Every field is immediately initialised except retry_list, which
> is never accessed until after the object is placed on a list.h list.
> 
> So this code never needed kzalloc_pool.

Well, that's a bit of a functional change so let us (ie: you ;)) do
that separately?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/