linux-kernel - Re: [RFC] Freescale MC13783 PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090811140500.2678b289.ospite@studenti.unina.it>
Date:	Tue, 11 Aug 2009 14:05:00 +0200
From:	Antonio Ospite <ospite@...denti.unina.it>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk,
	Daniel Ribeiro <drwyrm@...il.com>
Subject: Re: [RFC] Freescale MC13783 PMIC support

On Tue, 11 Aug 2009 11:07:42 +0200
Sascha Hauer <s.hauer@...gutronix.de> wrote:

> Hi all,
> 
> This series adds support for the Freescale MC13783 PMIC. The MC13783
> is connected via SPI, the first patch adds basic support for it in
> drivers/mfd. The rest of the patches can be applied independently.
> Individual Maintainers are on Cc, the whole series can be found on
> lkml and the Arm Linux Kernel mailing list.
> Please ignore the previous mail which lacked the intrductory mail.
> 
> Sascha
>

Hi Sascha,

the MC13783 is also named Atlas, isn't it?
Maybe you can add this name somewhere in comments or in Kconfig entry
to help greppers and web crawlers.

BTW, I only took a very brief look to some of your patches, and here's
some humble thoughts, sorry if I don't comment patch by patch.

There is a driver queued for inclusion in 2.6.31 for the PCAP2
PMIC, which is quite similar to MC13783. This driver uses the irq_chip
mechanism to expose the PMIC IRQs to be used as general IRQs in
sub-devices drivers (which you call client-devices AFAICS). Also, it
passed all the reviews so maybe you can give it a look to take some
other solution already accepted by reviewers, like passing sub-devices
via platform data (some of the phones which use PCAP2 don't have
touchscreen, for instance), generalize the driver so to handle multiple
PMICs in one system (quite unlikely scenario?), read actual pressure
in TS driver.

The latest (fixed) version of the core and ADC driver is in [1], but you
can find also the regulator and input drivers in [2] which are queued
for 2.6.32, the rtc driver can be found in [3]
(rtc-driver-for-pcap2-pmic-*.patch).

Regards,
   Antonio

[1]
http://git.kernel.org/?p=linux/kernel/git/sameo/mfd-2.6.git;a=blob;f=drivers/mfd/ezx-pcap.c;h=016be4938e4c4baac63168e2c478f335ae162ed9;hb=for-next

[2]
http://git.kernel.org/?p=linux/kernel/git/sameo/mfd-2.6.git;a=summary

[3] http://userweb.kernel.org/~akpm/mmotm/broken-out/

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

Content of type "application/pgp-signature" skipped