linux-kernel - Re: drivers/pci/quirks.c: irq_reroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Aug 2009 09:47:09 +0200
From:	Stefan Assmann <sassmann@...hat.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	Ingo Molnar <mingo@...e.hu>, Jeremy Fitzhardinge <jeremy@...p.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Olaf Dabrunz <Olaf.Dabrunz@....net>
Subject: Re: drivers/pci/quirks.c: irq_reroute_variant is dead code?

On 10.08.2009 18:32, Jesse Barnes wrote:
> [Corrected Stefan's address.]

Thanks Jesse! CCing Olaf as well.

> On Sat, 8 Aug 2009 16:45:20 +0200
> Ingo Molnar<mingo@...e.hu>  wrote:
>
>> * Jesse Barnes<jbarnes@...tuousgeek.org>  wrote:
>>
>>> On Tue, 28 Jul 2009 12:50:08 -0700
>>> Jeremy Fitzhardinge<jeremy@...p.org>  wrote:
>>>
>>>> quirk_reroute_to_boot_interrupts_intel() goes to some effort to
>>>> scan for a bunch of Intel devices and set
>>>> dev->irq_reroute_variant = INTEL_IRQ_REROUTE_VARIANT.  However,
>>>> as far as I can see that's the only reference to
>>>> dev->irq_reroute_variant and INTEL_IRQ_REROUTE_VARIANT, so the
>>>> whole thing appears to have no effect.
>>>>
>>>> Is it all dead code?  Is there something else which should be
>>>> there missing?
>>> Hm my quick look couldn't find a user either.  The initial patch
>>> to add that stuff (e1d3a90846b40ad3160bf4b648d36c6badad39ac) had
>>> an ACPI component, but it looks like that may have vanished
>>> somehow (maybe some of the IOAPIC code got shuffled around and
>>> this bit was missed?).
>>>
>>> Stefan or Ingo?
>> I dont remember ioapic interactions. Stefan?
>>
>> 	Ingo
>>

Actually the ACPI part of the commit got trashed by some major ACPI
rewrite. The changes in ACPI code made it non-trivial (as far as I can
see) to manipulate the ACPI IRQ for the relevant devices. I'm not an
ACPI expert and couldn't come up with a solution yet. I'm aware of the
fact that especially the ACPI part was considered arguable by some
people but it was the only place we found to alter the IRQ a driver will
get installed on.
I'd be happy to finally set this right. Any help is greatly appreciated
and I'll try to spend some time with recent ACPI code searching for
possible solutions.

   Stefan
--
Stefan Assmann         | Red Hat GmbH
Software Engineer      | Otto-Hahn-Strasse 20, 85609 Dornach
                        | HR: Amtsgericht Muenchen HRB 153243
                        | GF: Brendan Lane, Charlie Peters,
sassmann at redhat.com |     Michael Cunningham, Charles Cachera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/