linux-kernel - Re: [ofa-general] Re: [PATCH 10/14] infiniband: use printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908111017.22153.jackm@dev.mellanox.co.il>
Date:	Tue, 11 Aug 2009 10:17:21 +0300
From:	Jack Morgenstein <jackm@....mellanox.co.il>
To:	Roland Dreier <rdreier@...co.com>
Cc:	general@...ts.openfabrics.org,
	Marcin Slusarz <marcin.slusarz@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Slaby <jirislaby@...il.com>
Subject: Re: [ofa-general] Re: [PATCH 10/14] infiniband: use printk_once

On Monday 10 August 2009 20:42, Roland Dreier wrote:
> 
>  > I'm a bit nervous about this one.  
>  > printk_once will print once ONLY if CONFIG_PRINTK is set in include/linux/autoconf.h
>  > (i.e., when the kernel is configured).  Otherwise, it gets defined to printk --
>  > and it will always print in this case.
>  > (see 2.6.30.xx kernel include file "include/linux/kernel.h", lines 235, 249, and 272).
> 
> Umm... if CONFIG_PRINTK is turned off nothing prints, right?
Jiri Slaby pointed that out to me -- i.e., that printk itself is defined to do nothing but
return 0 if CONFIG_PRINTK is not defined. (I missed that when looking at file kernel.h).

I thought no answer was needed (sorry about that) -- Jiri was so obviously correct.

I've got no problem with the patch.

-Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/