linux-kernel - Re: [PATCH 1/3] perf tools: Factorize high level dso helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090812100851.GA18577@elte.hu>
Date:	Wed, 12 Aug 2009 12:08:51 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Mike Galbraith <efault@....de>,
	Brice Goglin <Brice.Goglin@...ia.fr>
Subject: Re: [PATCH 1/3] perf tools: Factorize high level dso helpers


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> On Wed, Aug 12, 2009 at 11:26:00AM +0200, Frederic Weisbecker wrote:
> > Factorize multiple definitions of high level dso helpers into the
> > symbol source file.
> > 
> > The side effect is a general export of the verbose and eprintf
> > debugging helpers into a new file dedicated to debugging purposes.
> > 
> > Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Mike Galbraith <efault@....de>
> > Cc: Brice Goglin <Brice.Goglin@...ia.fr>
> > ---
> >  tools/perf/Makefile           |    1 +
> >  tools/perf/builtin-annotate.c |   96 ----------------------------------------
> >  tools/perf/builtin-record.c   |    1 -
> >  tools/perf/builtin-report.c   |   97 -----------------------------------------
> >  tools/perf/builtin-stat.c     |    1 -
> >  tools/perf/builtin-top.c      |    4 --
> >  tools/perf/builtin.h          |    1 +
> >  tools/perf/perf.h             |    1 +
> >  tools/perf/util/symbol.c      |   97 +++++++++++++++++++++++++++++++++++++++++
> >  tools/perf/util/symbol.h      |   11 +++++
> >  10 files changed, 111 insertions(+), 199 deletions(-)
> > 
> > diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> > index de7beac..2aee21b 100644
> > --- a/tools/perf/Makefile
> > +++ b/tools/perf/Makefile
> > @@ -339,6 +339,7 @@ LIB_OBJS += util/pager.o
> >  LIB_OBJS += util/header.o
> >  LIB_OBJS += util/callchain.o
> >  LIB_OBJS += util/values.o
> > +LIB_OBJS += util/debug.o
> 
> 
> Damn, did I forgot to git-add util/debug.c ?
> 
> How could I fix this? Another pull request?

yeah. I've zapped those commits from perfcounters/core.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/