linux-kernel - [boot crash] Re: [tip:x86/mce3] x86, mce: use 64bit machine check code on 32bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090812113652.GA19632@elte.hu>
Date:	Wed, 12 Aug 2009 13:36:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	seto.hidetoshi@...fujitsu.com, ak@...ux.intel.com,
	tglx@...utronix.de, Yinghai Lu <yinghai@...nel.org>,
	Huang Ying <ying.huang@...el.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-tip-commits@...r.kernel.org
Subject: [boot crash] Re: [tip:x86/mce3] x86, mce: use 64bit machine check
	code on 32bit


* tip-bot for Andi Kleen <ak@...ux.intel.com> wrote:

> Commit-ID:  4efc0670baf4b14bc95502e54a83ccf639146125
> Gitweb:     http://git.kernel.org/tip/4efc0670baf4b14bc95502e54a83ccf639146125
> Author:     Andi Kleen <ak@...ux.intel.com>
> AuthorDate: Tue, 28 Apr 2009 19:07:31 +0200
> Committer:  H. Peter Anvin <hpa@...or.com>
> CommitDate: Thu, 28 May 2009 09:24:13 -0700
> 
> x86, mce: use 64bit machine check code on 32bit
> 
> The 64bit machine check code is in many ways much better than
> the 32bit machine check code: it is more specification compliant,
> is cleaner, only has a single code base versus one per CPU,
> has better infrastructure for recovery, has a cleaner way to communicate
> with user space etc. etc.
> 
> Use the 64bit code for 32bit too.
> 
> This is the second attempt to do this. There was one a couple of years
> ago to unify this code for 32bit and 64bit.  Back then this ran into some
> trouble with K7s and was reverted.
> 
> I believe this time the K7 problems (and some others) are addressed.
> I went over the old handlers and was very careful to retain
> all quirks.

This commit causes a new regression, it broke the bootup on one of 
my -tip testsystems, an older, Pentium-M based HP laptop (HP 
OmniBook 6000 EA).

The symptom is that the bootup hard-hangs after MCE init:

 [    0.022996] Mount-cache hash table entries: 512
 [    0.024996] Initializing cgroup subsys debug
 [    0.025996] Initializing cgroup subsys cpuacct
 [    0.026995] Initializing cgroup subsys devices
 [    0.027995] Initializing cgroup subsys freezer
 [    0.028995] mce: CPU supports 5 MCE banks

Kernel config attached. cpuinfo:

processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 8
model name	: 06/08
stepping	: 10
cpu MHz		: 846.372
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 sep mtrr pge mca cmov pat pse36 mmx fxsr sse up
bogomips	: 1692.74
clflush size	: 32
power management:

	Ingo

View attachment "config" of type "text/plain" (61538 bytes)

View attachment "config" of type "text/plain" (61539 bytes)