linux-kernel - Re: [tip:x86/urgent] x86, mce: therm_throt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090812024629.ADFC2526EC9@mailhub.coreip.homeip.net>
Date:	Tue, 11 Aug 2009 19:15:54 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Kevin Winchester <kjwinchester@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86, mce: therm_throt - change when we print
	messages

On Tue, Aug 11, 2009 at 09:31:14AM -0300, Kevin Winchester wrote:
> 2009/8/11 tip-bot for Dmitry Torokhov <dmitry.torokhov@...il.com>:
> >  static DEFINE_PER_CPU(__u64, next_check) = INITIAL_JIFFIES;
> >  static DEFINE_PER_CPU(unsigned long, thermal_throttle_count);
> > +static DEFINE_PER_CPU(bool, thermal_throttle_active);
> >
> >  static atomic_t therm_throt_en         = ATOMIC_INIT(0);
> >
> > @@ -96,24 +97,27 @@ static int therm_throt_process(int curr)
> >  {
> >        unsigned int cpu = smp_processor_id();
> >        __u64 tmp_jiffs = get_jiffies_64();
> > +       bool was_throttled = __get_cpu_var(thermal_throttle_active);
> > +       bool is_throttled = __get_cpu_var(thermal_throttle_active) = curr;
> 
> This seems a little odd (or perhaps my lack of experience is
> showing...) - should it be:
> 
> bool is_throttled = __get_cpu_var(thermal_throttle_active) == curr;
> 
> ?

No, you still want to assign the value to thermal_throttle_active.
is_throttled is just a temp so you don't need to invoke
__get_cpu_var(thermal_throttle_active) all over the function.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/