linux-kernel - Re: [GIT PULL] tracing: Syscalls trace events + perf support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090812143002.GB19882@elte.hu>
Date:	Wed, 12 Aug 2009 16:30:02 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jason Baron <jbaron@...hat.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Jiaying Zhang <jiayingz@...gle.com>,
	Martin Bligh <mbligh@...gle.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Masami Hiramatsu <mhiramat@...hat.com>
Subject: Re: [GIT PULL] tracing: Syscalls trace events + perf support


* Jason Baron <jbaron@...hat.com> wrote:

> On Wed, Aug 12, 2009 at 01:33:09PM +0200, Frederic Weisbecker wrote:
> > On Wed, Aug 12, 2009 at 01:03:07PM +0200, Ingo Molnar wrote:
> > > 
> > > one thing i noticed is that we dont seem to be catching 
> > > compat syscalls properly:
> > 
> > 
> > Oh right. While looking at fs/compat.c, it seems most of the
> > compat syscalls haven't been defined through the SYSCALL_DEFINE
> > macro.
> > 
> > Grr...
> > 
> 
> right. I mentioned this in a pervious mail that we weren't 
> handling compat syscalls. That said, the pervious syscall tracer 
> also had the same issue, so we haven't taken a step back. I guess 
> we need to convert some of the compat layer to use the 
> DEFINE_SYSCALL() macros. Also, there are a number of 64-bit 
> syscalls that don't use DEFINE_SYSCALL either. Those need to 
> converted as well. The patchset I submitted converted a couple of 
> them....

Those should come in separate patches as DEFINE_SYSCALL() coverage 
is useful to upstream as-is, even outside of syscall-tracing's 
scope.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/