linux-kernel - Re: [lm-sensors] [PATCH 3/5] [hwmon] add Freescale MC13783 adc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090812164252.GE11227@sirena.org.uk>
Date:	Wed, 12 Aug 2009 17:42:53 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Eric Piel <eric.piel@...mplin-utc.net>,
	Luotao Fu <l.fu@...gutronix.de>, lm-sensors@...sensors.org,
	Hans de Goede <hdegoede@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [lm-sensors] [PATCH 3/5] [hwmon] add Freescale MC13783 adc
	driver

On Wed, Aug 12, 2009 at 05:05:29PM +0200, Sascha Hauer wrote:

> ---
>  drivers/hwmon/Kconfig       |    6 ++
>  drivers/hwmon/Makefile      |    1 +
>  drivers/hwmon/mc13783-adc.c |  181 +++++++++++++++++++++++++++++++++++++++++++

Ideally there should be a Documentation/hwmon describing the chip and
the hwmon features it has.

> +	for (i = 0; i < entries; i++) {
> +		ret = device_create_file(&pdev->dev,
> +				&mc13783_adc_ctl[i].dev_attr);
> +		if (ret) {
> +			dev_err(&pdev->dev,
> +				"device_create_file failed with %d.\n", ret);
> +			goto out_err;
> +		}
> +	}

Could use sysfs_create_group() here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/