| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1250109930.7493.165.camel@lexx>
Date: Wed, 12 Aug 2009 15:45:30 -0500
From: Will Schmidt <will_schmidt@...t.ibm.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
rt-users <linux-rt-users@...r.kernel.org>,
Ingo Molnar <mingo@...e.hu>,
Steven Rostedt <rostedt@...dmis.org>,
Peter Zijlstra <peterz@...radead.org>,
Carsten Emde <ce@...g.ch>,
Clark Williams <williams@...hat.com>,
Frank Rowand <frank.rowand@...sony.com>,
Robin Gareus <robin@...eus.org>,
Gregory Haskins <ghaskins@...ell.com>,
Philippe Reynes <philippe.reynes@...smpp.fr>,
Fernando Lopez-Lezcano <nando@...ma.Stanford.EDU>,
Darren Hart <dvhltc@...ibm.com>, Jan Blunck <jblunck@...e.de>,
Sven-Thorsten Dietrich <sdietrich@...ell.com>,
Jon Masters <jcm@...hat.com>
Subject: Re: [ANNOUNCE] 2.6.31-rc4-rt1
On Tue, 2009-08-11 at 20:09 +0200, Thomas Gleixner wrote:
> On Wed, 5 Aug 2009, Will Schmidt wrote:
> > /test/willschm/linux-2.6.31-rtx/kernel/spinlock.c:103: error: implicit
> > declaration of function ‘_raw_atomic_spin_relax’
>
> Fix below. Thanks,
Thanks Thomas,
Still doesn't boot, but after turning on every spinlock and early
debug option I could find I have some more data. :-)
The .find_legacy_serial_ports function in the backtrace is very very
early during boot. I'll do a bit more looking around to see if it's
anything obvious,..
Thanks,
-Will
-----><-----
Found initrd at 0xc000000003b00000:0xc000000003c8d000
-> pSeries_init_early()
-> fw_cmo_feature_init()
CMO_PageSize = 4096
CMO not enabled, PrPSP=-1, SecPSP=-1
<- fw_cmo_feature_init()
<- pSeries_init_early()
=============================================
[ INFO: possible recursive locking detected ]
2.6.31-rc4-rt1-wms.aug12 #2
---------------------------------------------
swapper/0 is trying to acquire lock:
(devtree_lock){......}, at: [<c0000000006683fc>] .of_find_property+0x78/0x140
but task is already holding lock:
(devtree_lock){......}, at: [<c0000000006694f0>] .of_find_compatible_node+0x48/0x158
other info that might help us debug this:
1 lock held by swapper/0:
#0: (devtree_lock){......}, at: [<c0000000006694f0>] .of_find_compatible_node+0x48/0x158
stack backtrace:
Call Trace:
[c000000000fbf700] [c0000000000181ac] .show_stack+0x124/0x320 (unreliable)
[c000000000fbf7d0] [c00000000001a410] .dump_stack+0x28/0x3c
[c000000000fbf850] [c000000000118214] .validate_chain+0x6f4/0xed8
[c000000000fbf910] [c000000000119244] .__lock_acquire+0x84c/0x900
[c000000000fbfa10] [c00000000011a3ec] .lock_acquire+0x144/0x194
[c000000000fbfae0] [c0000000007ac620] ._atomic_spin_lock+0x58/0x84
[c000000000fbfb70] [c0000000006683fc] .of_find_property+0x78/0x140
[c000000000fbfc10] [c000000000668508] .of_get_property+0x44/0x78
[c000000000fbfcb0] [c000000000668f78] .of_device_is_compatible+0x48/0x118
[c000000000fbfd60] [c000000000669554] .of_find_compatible_node+0xac/0x158
[c000000000fbfe00] [c000000000b49db8] .find_legacy_serial_ports+0x358/0xb8c
[c000000000fbfee0] [c000000000b3d798] .setup_system+0x3d0/0x6c8
[c000000000fbff90] [c0000000000083c8] .start_here_common+0xc/0x44
BUG: spinlock lockup on CPU#0, swapper/0, c000000000ea9f48
Call Trace:
[c000000000fbf8f0] [c0000000000181ac] .show_stack+0x124/0x320 (unreliable)
[c000000000fbf9c0] [c00000000001a410] .dump_stack+0x28/0x3c
[c000000000fbfa40] [c0000000004785c4] ._raw_spin_lock+0x2a8/0x2e8
[c000000000fbfae0] [c0000000007ac62c] ._atomic_spin_lock+0x64/0x84
[c000000000fbfb70] [c0000000006683fc] .of_find_property+0x78/0x140
[c000000000fbfc10] [c000000000668508] .of_get_property+0x44/0x78
[c000000000fbfcb0] [c000000000668f78] .of_device_is_compatible+0x48/0x118
[c000000000fbfd60] [c000000000669554] .of_find_compatible_node+0xac/0x158
[c000000000fbfe00] [c000000000b49db8] .find_legacy_serial_ports+0x358/0xb8c
[c000000000fbfee0] [c000000000b3d798] .setup_system+0x3d0/0x6c8
[c000000000fbff90] [c0000000000083c8] .start_here_common+0xc/0x44
>
> tglx
>
> -------
> commit ffc969930727238b847176c203bdbe1f9dffe403
> Author: Thomas Gleixner <tglx@...utronix.de>
> Date: Tue Aug 11 20:03:47 2009 +0200
>
> locks: Fix PREEMPT=y, LOCKBREAK=y, DEBUG_LOCK_ALLOC=n compile
>
> Should be folded back into the atomic lock conversion
>
> Reported-by: Will Schmidt <will_schmidt@...t.ibm.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>
> diff --git a/kernel/lock-internals.h b/kernel/lock-internals.h
> index 4f0bc8b..76f694c 100644
> --- a/kernel/lock-internals.h
> +++ b/kernel/lock-internals.h
> @@ -9,8 +9,8 @@
> * (We do this in a function because inlining it would be excessive.)
> */
>
> -#define BUILD_LOCK_OPS(op, locktype) \
> -void __lockfunc _##op##_lock(locktype##_t *lock) \
> +#define BUILD_LOCK_OPS(prefix, op, locktype) \
> +void __lockfunc _##prefix##_lock(locktype##_t *lock) \
> { \
> for (;;) { \
> preempt_disable(); \
> @@ -20,15 +20,15 @@ void __lockfunc _##op##_lock(locktype##_t *lock) \
> \
> if (!(lock)->break_lock) \
> (lock)->break_lock = 1; \
> - while (!op##_can_lock(lock) && (lock)->break_lock) \
> + while (!prefix##_can_lock(lock) && (lock)->break_lock) \
> _raw_##op##_relax(&lock->raw_lock); \
> } \
> (lock)->break_lock = 0; \
> } \
> \
> -EXPORT_SYMBOL(_##op##_lock); \
> +EXPORT_SYMBOL(_##prefix##_lock); \
> \
> -unsigned long __lockfunc _##op##_lock_irqsave(locktype##_t *lock) \
> +unsigned long __lockfunc _##prefix##_lock_irqsave(locktype##_t *lock) \
> { \
> unsigned long flags; \
> \
> @@ -42,23 +42,23 @@ unsigned long __lockfunc _##op##_lock_irqsave(locktype##_t *lock) \
> \
> if (!(lock)->break_lock) \
> (lock)->break_lock = 1; \
> - while (!op##_can_lock(lock) && (lock)->break_lock) \
> + while (!prefix##_can_lock(lock) && (lock)->break_lock) \
> _raw_##op##_relax(&lock->raw_lock); \
> } \
> (lock)->break_lock = 0; \
> return flags; \
> } \
> \
> -EXPORT_SYMBOL(_##op##_lock_irqsave); \
> +EXPORT_SYMBOL(_##prefix##_lock_irqsave); \
> \
> -void __lockfunc _##op##_lock_irq(locktype##_t *lock) \
> +void __lockfunc _##prefix##_lock_irq(locktype##_t *lock) \
> { \
> - _##op##_lock_irqsave(lock); \
> + _##prefix##_lock_irqsave(lock); \
> } \
> \
> -EXPORT_SYMBOL(_##op##_lock_irq); \
> +EXPORT_SYMBOL(_##prefix##_lock_irq); \
> \
> -void __lockfunc _##op##_lock_bh(locktype##_t *lock) \
> +void __lockfunc _##prefix##_lock_bh(locktype##_t *lock) \
> { \
> unsigned long flags; \
> \
> @@ -67,9 +67,9 @@ void __lockfunc _##op##_lock_bh(locktype##_t *lock) \
> /* irq-disabling. We use the generic preemption-aware */ \
> /* function: */ \
> /**/ \
> - flags = _##op##_lock_irqsave(lock); \
> + flags = _##prefix##_lock_irqsave(lock); \
> local_bh_disable(); \
> local_irq_restore(flags); \
> } \
> \
> -EXPORT_SYMBOL(_##op##_lock_bh)
> +EXPORT_SYMBOL(_##prefix##_lock_bh)
> diff --git a/kernel/rwlock.c b/kernel/rwlock.c
> index 35460b3..eaf34c8 100644
> --- a/kernel/rwlock.c
> +++ b/kernel/rwlock.c
> @@ -146,8 +146,8 @@ EXPORT_SYMBOL(_write_lock);
> * _[read|write]_lock_irqsave()
> * _[read|write]_lock_bh()
> */
> -BUILD_LOCK_OPS(read, rwlock);
> -BUILD_LOCK_OPS(write, rwlock);
> +BUILD_LOCK_OPS(read, read, rwlock);
> +BUILD_LOCK_OPS(write, write, rwlock);
>
> #endif /* CONFIG_PREEMPT */
>
> diff --git a/kernel/spinlock.c b/kernel/spinlock.c
> index 6a3c0c4..e3194d5 100644
> --- a/kernel/spinlock.c
> +++ b/kernel/spinlock.c
> @@ -100,7 +100,7 @@ EXPORT_SYMBOL(_atomic_spin_lock);
> * _atomic_spin_lock_irqsave()
> * _atomic_spin_lock_bh()
> */
> -BUILD_LOCK_OPS(atomic_spin, atomic_spinlock);
> +BUILD_LOCK_OPS(atomic_spin, spin, atomic_spinlock);
>
> #endif /* CONFIG_PREEMPT */
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists