linux-kernel - Re: [RFC patch] init default dma_ops to prepare intel_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2009 09:26:12 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	luming.yu@...il.com, fenghua.yu@...el.com, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [RFC patch] init default dma_ops to prepare intel_iommu_init 
 failure

On Thu, 2009-08-13 at 12:18 +0900, FUJITA Tomonori wrote:
> > Duh, yeah, intel_iommu_init() fails, it doesn't work.
> > 
> > X86 falls back into nommu_dam_ops but IA64 has nothing.
> > 
> > pci_swiotlb_init() can't set swiotlb to 1 or overwrite dma_ops? If it
> > sets swiotlb to 1, intel_iommu_init() fails.
> > 
> > A quick fix could be something like this:
> 
> Oops, here's a good one.

Closer, but don't we still want to free the swiotlb buffers if the iommu
init _does_ actually work?

And we want the same on x86 too -- we want swiotlb, not nommu.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/