linux-kernel - Re: [PATCH][RT] Fix build errors in rtmutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <520f0cf10908130404p86c991k85dcd797e7e21baa@mail.gmail.com>
Date:	Thu, 13 Aug 2009 13:04:57 +0200
From:	John Kacur <jkacur@...il.com>
To:	Sven-Thorsten Dietrich <sdietrich@...ell.com>
Cc:	linux-rt-users <linux-rt-users@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][RT] Fix build errors in rtmutex

On Thu, Aug 13, 2009 at 6:41 AM, Sven-Thorsten
Dietrich<sdietrich@...ell.com> wrote:
> Subject: Fix up "too few parameters to function" build errors in rtmutex
> From: Sven-Thorsten Dietrich <sdietrich@...e.de>
>
> Signed-off-by: Sven-Thorsten Dietrich <sdietrich@...e.de>
> Index: b/kernel/rtmutex.c
> ===================================================================
> --- a/kernel/rtmutex.c
> +++ b/kernel/rtmutex.c
> @@ -1513,7 +1513,8 @@ int rt_mutex_start_proxy_lock(struct rt_
>
>        mark_rt_mutex_waiters(lock);
>
> -       if (!rt_mutex_owner(lock) || try_to_steal_lock(lock, task)) {
> +       if (!rt_mutex_owner(lock) ||
> +          try_to_steal_lock(lock, task, STEAL_NORMAL)) {
>                /* We got the lock for task. */
>                debug_rt_mutex_lock(lock);
>                rt_mutex_set_owner(lock, task, 0);
> @@ -1522,7 +1523,8 @@ int rt_mutex_start_proxy_lock(struct rt_
>                return 1;
>        }
>
> -       ret = task_blocks_on_rt_mutex(lock, waiter, task, detect_deadlock);
> +       ret = task_blocks_on_rt_mutex(lock, waiter, task, detect_deadlock,
> +                                    flags);
>
>        if (ret && !waiter->task) {
>                /*
> Index: b/kernel/trace/ring_buffer.c
> ===================================================================
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -2522,7 +2522,7 @@ ring_buffer_peek(struct ring_buffer *buf
>        if (event && event->type_len == RINGBUF_TYPE_PADDING)
>                rb_advance_reader(cpu_buffer);
>        if (dolock)
> -               atomic_)spin_unlock(&cpu_buffer->reader_lock);
> +               atomic_spin_unlock(&cpu_buffer->reader_lock);
>        local_irq_restore(flags);
>
>        if (event && event->type_len == RINGBUF_TYPE_PADDING) {
>
>

Hi Sven

I have to admit I'm scratching my head over this one, I don't see any
rt trees that it applies to. Which version are you referring to here?

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/