linux-kernel - Re: [PATCH] Combine two one-character CR-LF writes into one two-character write for O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090813205018.4d781c74@lxorguk.ukuu.org.uk>
Date:	Thu, 13 Aug 2009 20:50:18 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David VomLehn <dvomlehn@...co.com>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] Combine two one-character CR-LF writes into one
 two-character write for O_ONLCR

> do_output_char() function uses the struct tty_operations function write_room()
> to determine whether it is possible to write two characters. It uses
> tty_put_char() for each character which, for the USB generic serial driver,
> translates into a write() for each character. For the USB generic serial
> driver the value returned by write_room() only applies to the next write().

The USB serial driver is broken, fix it instead. It's not even hard to
fix.

> +			tty->ops->write(tty, crlf, ARRAY_SIZE(crlf));
> +			return ARRAY_SIZE(crlf);

Emphatic NAK. Someone needs to actually fix the broken USB drivers for
once. This is just one example of where the device will go kersplat if its
broken, others include things like losing flow control.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/