linux-kernel - Re: [PATCH] arch-x86-pci-swiotlb-cleanup-patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090813202948.GA20829@elte.hu>
Date:	Thu, 13 Aug 2009 22:29:48 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Marin Mitov <mitov@...p.bas.bg>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] arch-x86-pci-swiotlb-cleanup-patch


* Marin Mitov <mitov@...p.bas.bg> wrote:

> Hi all,
> 
> This is a simple cleanup patch for arch/x86/kernel/pci-swiotlb.c 
> file.
> 
> Deleted functions are already in lib/swiotlb.c, so no need to be 
> duplicated.
> 
> The patch is against linux-2.6.31-rc5, compile/run tested on 
> x86_64.
> 
> Best regards,
> 
> Marin Mitov
> 
> Signed-off-by: Marin Mitov <mitov@...p.bas.bg>
> 
> =====================================================
> --- a/arch/x86/kernel/pci-swiotlb.c	2009-08-13 16:05:28.000000000 +0300
> +++ b/arch/x86/kernel/pci-swiotlb.c	2009-08-13 16:13:09.000000000 +0300
> @@ -13,31 +13,6 @@
>  
>  int swiotlb __read_mostly;
>  
> -void * __init swiotlb_alloc_boot(size_t size, unsigned long nslabs)
> -{
> -	return alloc_bootmem_low_pages(size);
> -}
> -
> -void *swiotlb_alloc(unsigned order, unsigned long nslabs)
> -{
> -	return (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN, order);
> -}
> [...]

Fujita Tomonori has already done this in these swiotlb commits:

  bb52196: swiotlb: remove unused swiotlb_alloc()
  3885123: swiotlb: remove unused swiotlb_alloc_boot()

about a month ago. You can find those changes in -tip:

  http://people.redhat.com/mingo/tip.git/README

and in linux-next as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/