linux-kernel - Re: [RFC patch] init default dma_ops to prepare intel_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3877989d0908130037j5f9b1594q61e51c544a254b68@mail.gmail.com>
Date:	Thu, 13 Aug 2009 15:37:54 +0800
From:	Luming Yu <luming.yu@...il.com>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	fenghua.yu@...el.com, dwmw2@...radead.org, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [RFC patch] init default dma_ops to prepare intel_iommu_init 
	failure

On Thu, Aug 13, 2009 at 3:14 PM, FUJITA
Tomonori<fujita.tomonori@....ntt.co.jp> wrote:
> On Thu, 13 Aug 2009 15:03:20 +0800
> Luming Yu <luming.yu@...il.com> wrote:
>
>> Thanks for another workaround, we should be working on deleting wrong
>> assumption of"iommu_deteced == iommu working", Not just workaround. My
>> patch could break something.. but it is just a start towards right
>> goal..
>
> As I explained, your patch doesn't go toward the right goal.

The goal is to decouple dma_ops init and iommu_detect.
In that sense, my patch is right.

>
> And if you want to fix this problem right now, my workaround patch is
> much better than yours; it doesn't waste 64MB.

My patch needs some fixes to get something back when
assigning intel_dma_ops to dma_ops, since we don't want resource
associated with old dma_ops get lost as you and David pointed out.
Please note just pursuing workaround will end up with more pain
than that being relieved
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/