linux-kernel - Re: [PATCH 5/6] new kfifo API v0.3 - add kfifo_skip, kfifo_from_user and kfifo_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200908141425.42220.arnd@arndb.de>
Date:	Fri, 14 Aug 2009 14:25:42 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH 5/6] new kfifo API v0.3 - add kfifo_skip, kfifo_from_user and kfifo_to_user

On Friday 14 August 2009, Stefani Seibold wrote:
> This is patch 5/6 of the new kfifo API:
>  kfifo_reset_out() to lockless save discard the fifo output
>  Add kfifo_skip() to skip a number of output bytes
>  Add kfifo_from_user() to copy user space data into the fifo
>  Add kfifo_to_user() to copy fifo data to user space
>  Do some code reorg

kfifo_skip is missing a comment regarding what it does,
and as with the other patches, the description should
line out why this is done, not what you do.

> Signed-off-by: Stefani Seibold <stefani@...bold.net>
 
Otherwise,
Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/